Downgrade neptune to v1.1.x. #1322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
requested review from
cryptonemo and
dignifiedquire
as code owners
|
I think this is defunct and will be resolved differently in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some problems reported in #1320 appear to be caused by neptune v1.2.0 — which has not actually been incorporated in a
rust-fil-proofsrelease yet. We should downgrade to1.1.2for now. I'm only specifying1.1here so we will get any further patches needed before moving to2.x. We may need new API/FFI releases or branches in order to get a revised version of https://github.com/filecoin-project/lotus/tree/feat/proofs-5.2.3 working. We should do that, though, so wider testing of multicore SDR can continue.