Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opencl3 crate to latest version 0.9 #72

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Update opencl3 crate to latest version 0.9 #72

merged 1 commit into from
Sep 28, 2022

Conversation

shawnrader
Copy link
Contributor

  • Update rust version to 1.62.1

  • Certain opencl3 APIs now required to be called as unsafe

@shawnrader
Copy link
Contributor Author

Currently in draft while I investigate CI failures

@shawnrader shawnrader self-assigned this Sep 15, 2022
@shawnrader shawnrader marked this pull request as ready for review September 15, 2022 22:30
Copy link
Collaborator

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things/comments.

rust-toolchain Outdated Show resolved Hide resolved
src/opencl/mod.rs Outdated Show resolved Hide resolved
src/opencl/utils.rs Outdated Show resolved Hide resolved
src/cuda/mod.rs Outdated Show resolved Hide resolved
src/opencl/mod.rs Outdated Show resolved Hide resolved
@shawnrader shawnrader force-pushed the opencl3 branch 2 times, most recently from 52bae34 to bef0337 Compare September 16, 2022 18:20
Cargo.toml Outdated Show resolved Hide resolved
 - Update rust version to 1.56.1

 - Certain opencl3 APIs now required to be called as unsafe
@vmx vmx merged commit ff93a64 into master Sep 28, 2022
@vmx vmx deleted the opencl3 branch September 28, 2022 14:22
@vmx
Copy link
Collaborator

vmx commented Sep 28, 2022

@shawnrader I dared to merge it, as I wanted to have the breaking change information (that we no use Rust 2021) in the commit message.

@vmx vmx mentioned this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants