-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sql): user numeric type to represent numbers #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
======================================
Coverage 42.3% 42.3%
======================================
Files 25 25
Lines 1897 1897
======================================
Hits 804 804
Misses 966 966
Partials 127 127 |
frrist
force-pushed
the
frrist/fil-numeric
branch
from
December 16, 2020 23:10
aa8d9d1
to
cf103db
Compare
iand
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fold #301 into this one so we have all the changes to numerics in a singfe schema change
frrist
force-pushed
the
frrist/fil-numeric
branch
from
January 4, 2021 20:48
3303513
to
286f46e
Compare
frrist
force-pushed
the
frrist/fil-numeric
branch
from
January 11, 2021 19:44
286f46e
to
853cfce
Compare
frrist
changed the title
chore(sql): user numeric types to represent number
chore(sql): user numeric type to represent numbers
Jan 12, 2021
iand
added a commit
that referenced
this pull request
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
together with #301 closes #244. will need a rebase if #301 goes in first.