Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sql): user numeric type to represent numbers #327

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Conversation

frrist
Copy link
Member

@frrist frrist commented Dec 16, 2020

together with #301 closes #244. will need a rebase if #301 goes in first.

@frrist frrist requested a review from iand December 16, 2020 23:07
@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #327 (c80cab9) into master (53c84ac) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #327   +/-   ##
======================================
  Coverage    42.3%   42.3%           
======================================
  Files          25      25           
  Lines        1897    1897           
======================================
  Hits          804     804           
  Misses        966     966           
  Partials      127     127           

@frrist frrist force-pushed the frrist/fil-numeric branch from aa8d9d1 to cf103db Compare December 16, 2020 23:10
Copy link
Contributor

@iand iand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fold #301 into this one so we have all the changes to numerics in a singfe schema change

@frrist frrist force-pushed the frrist/fil-numeric branch from 286f46e to 853cfce Compare January 11, 2021 19:44
@frrist frrist changed the title chore(sql): user numeric types to represent number chore(sql): user numeric type to represent numbers Jan 12, 2021
@frrist frrist merged commit f0312c3 into master Jan 12, 2021
@frrist frrist deleted the frrist/fil-numeric branch January 12, 2021 20:54
iand added a commit that referenced this pull request Jan 15, 2021
iand added a commit that referenced this pull request Jan 15, 2021
iand added a commit that referenced this pull request Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store fil value in db as numeric type
3 participants