Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: devtools: main.go #5658

Merged
merged 3 commits into from
Feb 8, 2023
Merged

fix: devtools: main.go #5658

merged 3 commits into from
Feb 8, 2023

Conversation

bhaskarvilles
Copy link
Contributor

This version of the code separates the different responsibilities into separate functions, and uses the log package instead of os.Exit() and panic() to handle errors. Additionally, it uses the ioutil package instead of os package to read the file, which simplify the code and it also returns errors instead of panicking on them, making it easier to handle them at a higher level in the application.

This version of the code separates the different responsibilities into separate functions, and uses the log package instead of `os.Exit()` and `panic()` to handle errors.
Additionally, it uses the ioutil package instead of os package to read the file, which simplify the code and it also returns errors instead of panicking on them, making it easier to handle them at a higher level in the application.
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Merging #5658 (bec0d76) into master (50b01d1) will decrease coverage by 1%.
The diff coverage is n/a.

❗ Current head bec0d76 differs from pull request most recent head dce7f12. Consider uploading reports for the commit dce7f12 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5658   +/-   ##
======================================
- Coverage      26%     26%   -1%     
======================================
  Files         612     613    +1     
  Lines       69453   69465   +12     
======================================
- Hits        18076   18075    -1     
- Misses      48991   49006   +15     
+ Partials     2386    2384    -2     

venus-devtool/inline-gen/main.go Outdated Show resolved Hide resolved
venus-devtool/inline-gen/main.go Outdated Show resolved Hide resolved
venus-devtool/inline-gen/main.go Outdated Show resolved Hide resolved
venus-devtool/inline-gen/main.go Outdated Show resolved Hide resolved
@simlecode
Copy link
Collaborator

Thank you for your PR!

@bhaskarvilles
Copy link
Contributor Author

Thank you for your PR!

Can you fix this for me, I'm in a medical emergency?? I'll make you as collaborator.

@simlecode
Copy link
Collaborator

Thank you for your PR!

Can you fix this for me, I'm in a medical emergency?? I'll make you as collaborator.

yea, I can, please make me as collaborator.

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simlecode simlecode merged commit 95604cc into filecoin-project:master Feb 8, 2023
@bhaskarvilles
Copy link
Contributor Author

Hey @simlecode This contribution eligible for Filecoin Community PR Rewards program ?

@Joss-Hua
Copy link
Collaborator

hi, @bhaskarvilles, sorry there is no reward for single behavior, but do you want to become a long-term contributor to the Venus community and get some rewards?

@bhaskarvilles
Copy link
Contributor Author

bhaskarvilles commented Feb 20, 2023

hi, @bhaskarvilles, sorry there is no reward for single behavior, but do you want to become a long-term contributor to the Venus community and get some rewards?

Hey @Joss-Hua , can you give me more details please?

@Joss-Hua
Copy link
Collaborator

hi, @bhaskarvilles, sorry there is no reward for single behavior, but do you want to become a long-term contributor to the Venus community and get some rewards?

Hey @Joss-Hua , can you give me more details please?

What is your filecoin slack handle? I'll contact you.

@bhaskarvilles
Copy link
Contributor Author

hi, @bhaskarvilles, sorry there is no reward for single behavior, but do you want to become a long-term contributor to the Venus community and get some rewards?

Hey @Joss-Hua , can you give me more details please?

What is your filecoin slack handle? I'll contact you.

My handle is bhaskarvilles, I'm also in the venus fil channel also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants