-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: devtools: main.go #5658
fix: devtools: main.go #5658
Conversation
This version of the code separates the different responsibilities into separate functions, and uses the log package instead of `os.Exit()` and `panic()` to handle errors. Additionally, it uses the ioutil package instead of os package to read the file, which simplify the code and it also returns errors instead of panicking on them, making it easier to handle them at a higher level in the application.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5658 +/- ##
======================================
- Coverage 26% 26% -1%
======================================
Files 612 613 +1
Lines 69453 69465 +12
======================================
- Hits 18076 18075 -1
- Misses 48991 49006 +15
+ Partials 2386 2384 -2 |
Thank you for your PR! |
Can you fix this for me, I'm in a medical emergency?? I'll make you as collaborator. |
yea, I can, please make me as collaborator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @simlecode This contribution eligible for Filecoin Community PR Rewards program ? |
hi, @bhaskarvilles, sorry there is no reward for single behavior, but do you want to become a long-term contributor to the Venus community and get some rewards? |
Hey @Joss-Hua , can you give me more details please? |
What is your filecoin slack handle? I'll contact you. |
My handle is bhaskarvilles, I'm also in the venus fil channel also |
This version of the code separates the different responsibilities into separate functions, and uses the log package instead of
os.Exit()
andpanic()
to handle errors. Additionally, it uses the ioutil package instead of os package to read the file, which simplify the code and it also returns errors instead of panicking on them, making it easier to handle them at a higher level in the application.