Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate nv18 #5726

Merged
merged 182 commits into from
Feb 16, 2023
Merged

feat: integrate nv18 #5726

merged 182 commits into from
Feb 16, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

#5550

改动 (Proposed Changes)

venus nv18 代码合并详情

重要修改

  1. 升级 filecoin-ffi & test-vectors
  2. 增加 f4 地址相关实现(pkg/crypto/delegated),验证消息时需对地址特殊处理
  3. 增加 ActorV5,相关使用地方要兼容 ActorV4
  4. 增加 ETH 类型、事件、接口
  5. MessageReceipt 增加 v1 版本
  6. 调整 TipSetKey UnmarshalCBORMarshalCBOR 实现,原先和 lotus 实现不一样
  7. 命令行增加 evm 相关命令(cmd/evm.go)
  8. CallGasCallWithGas 调整实现
  9. actor 状态迁移函数,升级高度
  10. vmOpt 增加字段:Timestamp TipSetGetter ActorDebugging ReturnEvents
  11. 新增接口:ChainGetEvents
  12. StateSectorGetInfosector 不存在时返回 nil
  13. 配置文件增加 fevm 字段
  14. 更新 builtin actors(venus-shared/actors)

pr 整理

go-jsonrpc

常规 (命令行 依赖 测试)

9436 9471 9590 9572 9632 9633 9741 9604

重要(nv18)

9515 9599 9784 9334 9533 9624 9636 9654 9664 9687 9599 9838 9886
9831 9915 9929 9931 9904 9958 10004 10011 10007 9965 10072 10056
10117 10124 9999 10131 10144 10095 10152 10160 10119 10225 10189
10230 10228 10216 10259 10248

ETH

pr 过多,可以对照文件来看看:

  • 类型:venus-shared/actors/types
  • 接口定义:venus-shared/api/chain/v1/eth
  • 接口实现:app/submodule/eth pkg/ethhashloopup
  • 事件:pkg/events/filter

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode self-assigned this Feb 15, 2023
@simlecode simlecode added the nv18 nv18-fevm label Feb 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Merging #5726 (c4233a1) into master (23f63b9) will decrease coverage by 2%.
The diff coverage is 15%.

❗ Current head c4233a1 differs from pull request most recent head 17da6d3. Consider uploading reports for the commit 17da6d3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #5726     +/-   ##
========================================
- Coverage      26%     24%     -2%     
========================================
  Files         612     644     +32     
  Lines       69453   78118   +8665     
========================================
+ Hits        18085   19393   +1308     
- Misses      48981   56125   +7144     
- Partials     2387    2600    +213     

@simlecode simlecode requested a review from diwufeiwen February 15, 2023 07:30
Copy link
Contributor

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hunjixin hunjixin merged commit ccf8ceb into master Feb 16, 2023
@hunjixin hunjixin deleted the feat/nv18-fevm branch February 16, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nv18 nv18-fevm
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants