-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate nv18 #5726
Merged
Merged
feat: integrate nv18 #5726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5726 +/- ##
========================================
- Coverage 26% 24% -2%
========================================
Files 612 644 +32
Lines 69453 78118 +8665
========================================
+ Hits 18085 19393 +1308
- Misses 48981 56125 +7144
- Partials 2387 2600 +213 |
hunjixin
reviewed
Feb 16, 2023
hunjixin
reviewed
Feb 16, 2023
hunjixin
reviewed
Feb 16, 2023
hunjixin
reviewed
Feb 16, 2023
hunjixin
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的Issues (Related Issues)
#5550
改动 (Proposed Changes)
venus nv18 代码合并详情
重要修改
filecoin-ffi
&test-vectors
f4
地址相关实现(pkg/crypto/delegated),验证消息时需对地址特殊处理ActorV5
,相关使用地方要兼容ActorV4
ETH
类型、事件、接口MessageReceipt
增加v1
版本TipSetKey
UnmarshalCBOR
和MarshalCBOR
实现,原先和lotus
实现不一样evm
相关命令(cmd/evm.go)CallGas
和CallWithGas
调整实现Timestamp
TipSetGetter
ActorDebugging
ReturnEvents
ChainGetEvents
StateSectorGetInfo
:sector
不存在时返回nil
fevm
字段builtin actors
(venus-shared/actors)pr 整理
go-jsonrpc
常规 (命令行 依赖 测试)
9436 9471 9590 9572 9632 9633 9741 9604
重要(nv18)
9515 9599 9784 9334 9533 9624 9636 9654 9664 9687 9599 9838 9886
9831 9915 9929 9931 9904 9958 10004 10011 10007 9965 10072 10056
10117 10124 9999 10131 10144 10095 10152 10160 10119 10225 10189
10230 10228 10216 10259 10248
ETH
pr 过多,可以对照文件来看看:
附注 (Additional Info)
自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that: