Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Fixed solution configurations in ya/wasdk #16190

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Sep 13, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@0x5bfa 0x5bfa changed the title Update Files.sln Code Quality: Fixed solution configuration for ya/wasdk Sep 13, 2024
@0x5bfa 0x5bfa changed the title Code Quality: Fixed solution configuration for ya/wasdk Code Quality: Fixed solution configurations in ya/wasdk Sep 13, 2024
@hez2010
Copy link
Member

hez2010 commented Sep 14, 2024

In long term we should migrate to the new slnx format instead of the sln format so that things are eaiser to maintain.

@0x5bfa
Copy link
Member Author

0x5bfa commented Sep 14, 2024

I wonder when they support it in msbuild but it looks really promising.

@yaira2 yaira2 merged commit 7788536 into files-community:ya/wasdk Sep 15, 2024
5 of 6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-WASDK1.6 branch September 15, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants