Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Upgrade Microsoft.WindowsAppSDK to 1.5.250108004 #16709

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

Lamparter
Copy link
Contributor

Resolved / Related Issues

Only a small dependency update.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files
  2. Test various functionality

Upgrades WinAppSDK to 1.5.250108004. Upgrading winappsdk is always a good practice since it comes with bug fixes and performance improvements which is vital for an app like Files.

@yaira2
Copy link
Member

yaira2 commented Jan 16, 2025

Has the changelog been published yet?

@0x5bfa
Copy link
Member

0x5bfa commented Jan 16, 2025

@Lamparter
Copy link
Contributor Author

Fixed another potential issue where a menu off a CommandBar may incorrectly open up instead of down when the CommandBar is at the bottom of the window.

This doesn't affect Files

Fixed a potential crash when running on older graphics hardware.

I'm not sure of the details exactly but this might fix crashes for some
Though I doubt it.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 16, 2025
@yaira2 yaira2 merged commit aef53d8 into files-community:main Jan 16, 2025
6 checks passed
@Lamparter Lamparter deleted the appsdk-1.5.250108004 branch January 16, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants