-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow AppMetadata to be passed in as a target argument #272
Allow AppMetadata to be passed in as a target argument #272
Conversation
I suggest we create: type Target = string | AppMetadata; And update raiseIntent(intent: string, target: Target) : Listener; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WG feedback - merge this and raise a separate PR to introduce a type for target (see @mattjamieson comment)
Sorry, in with another comment at the last minute. If we're updating |
I have created a new PR for @mattjamieson's proposed edits #279 |
This PR contributes changes proposed in #270
name
argument in open() totarget
and adds AppMetadata as a valid type for that argumenttarget
argument inraiseIntent()