Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#321 First attempt at domains, controls and structure #323

Merged
merged 9 commits into from
Aug 8, 2024

Conversation

jpgough-ms
Copy link
Member

No description provided.

@jpgough-ms jpgough-ms requested a review from a team as a code owner August 2, 2024 09:36
@yt-ms
Copy link
Contributor

yt-ms commented Aug 2, 2024

Explaining what I am meaning by some of the terms:

  • Control Requirement: this is a high-level statement of what is needed, e.g. "all code in production must meet appropriate architecture quality characteristics (a.k.a. NFRs)".
  • Control Instance: this is the way a particular requirement is implemented, and there may be multiple of these for a single requirement. E.g. "All systems in MyDepartment are reviewed by an approved architect before entering production, and a record of that is captured in the central review log repository".
  • Control Evidence: this is the data that shows that a particular Control Instance was satisfied. E.g. "On 2024-05-27, jpgough-ms did an architecture review of MySystem and approved it meets appropriate AQCs, as evidenced by document http://myfirm/reviewlog-123" (except expressed as data rather than text).

@yt-ms
Copy link
Contributor

yt-ms commented Aug 2, 2024

There's also the potential for automated testing of the evidence, which might be done by a REGO expression in the Control Instance operating on the Control Evidence data (with hooks to pull additional info from linked repositories).

@jpgough-ms
Copy link
Member Author

jpgough-ms commented Aug 5, 2024

Couple of things to change on the PR based on this feedback:

  • Add evidence-id and evidence-link if @yt-ms agrees to the general approach
  • Move the definition out of nodes, so it could be referenced from relationships if we decide to go that way

@jpgough-ms jpgough-ms merged commit cc2607a into finos:main Aug 8, 2024
3 checks passed
@jpgough-ms jpgough-ms deleted the august branch August 8, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants