Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-asset as new node-type #474

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Add data-asset as new node-type #474

merged 3 commits into from
Oct 16, 2024

Conversation

arhy
Copy link
Contributor

@arhy arhy commented Oct 14, 2024 •
edited
Loading

Addresses removal of database in #450

@arhy arhy requested a review from a team as a code owner October 14, 2024 21:07
rocketstack-matt
rocketstack-matt requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@rocketstack-matt rocketstack-matt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest for now we add data-asset but don't remove database until we have broader agreement, I think that will also require us to update some examples to change where it is referenced.

@arhy arhy changed the title Remove database, add data-asset Add data-asset as new node-type Oct 15, 2024
@arhy
Copy link
Contributor Author

arhy commented Oct 15, 2024

Acknowledged. Reverted database.

@rocketstack-matt rocketstack-matt merged commit e68a228 into finos:main Oct 16, 2024
3 checks passed
@jpgough-ms jpgough-ms mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketstack-matt rocketstack-matt rocketstack-matt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arhy @rocketstack-matt