Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI #599

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Fix CLI #599

merged 3 commits into from
Nov 18, 2024

Conversation

willosborne
Copy link
Member

Fixes a number of issues accidentally introduced as part of splitting up the project into modules.

  • issue with path for loading meta schema
  • copyfiles not copying spectral functions on unix
  • schema directory name wrong
  • error logging insufficient
  • cli parse command using wrong name for schemaDirectory arg

This PR highlights that integration tests are urgently needed!

Outstanding issues this PR does not fix:

  • build step does not seem to correctly chmod index.js
  • github actions can't build the CLI with the new modules - we can't publish

Tests to check:

calm validate -p ../calm/pattern/api-gateway.json -i ../calm/samples/api-gateway-instantiation.json
calm generate -p ../calm/pattern/api-gateway.json -o test.json

@Thels
Copy link
Member

Thels commented Nov 18, 2024

This PR highlights that integration tests are urgently needed!

Completely agree, the CLI is a simple module, I'll get on this later today.

jpgough-ms
jpgough-ms previously approved these changes Nov 18, 2024
@Thels
Copy link
Member

Thels commented Nov 18, 2024

Suggestion isn't required - just a minor thing :)

Thels
Thels previously approved these changes Nov 18, 2024
Copy link
Member

@Thels Thels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - suggestion isn't mandatory.

shared/src/commands/generate/schema-directory.ts Outdated Show resolved Hide resolved
@willosborne willosborne dismissed stale reviews from Thels and jpgough-ms via 462a146 November 18, 2024 14:36
@Thels Thels self-requested a review November 18, 2024 14:43
@Thels Thels merged commit acca69b into finos:main Nov 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants