Add ecosystem to node spec and tie flows into core.json #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeighFinegold
force-pushed
the
calm-docify
branch
2 times, most recently
from
3b34098 to
9a50a98
Compare
|
I know this isn't added in this PR, but I do think we should break out the way controls are modelled here, each control should be a separate document rather than all bundled, but happy to discuss that in a separate PR. |
LeighFinegold
force-pushed
the
calm-docify
branch
from
9a50a98 to
666a1fa
Compare
jpgough-ms
approved these changes
Dec 11, 2024
| @@ -175,6 +181,7 @@ | |||
| "node-type-definition": { | |||
| "enum": [ | |||
| "actor", | |||
| "ecosystem", | |||
There was a problem hiding this comment.
I'm not sure what this is for? Will continue looking through the review.
There was a problem hiding this comment.
Explained on linked issue. If we don't want to pull over that terminology, happy to go with something else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the feature request detailed in issue 650 by implementing the following enhancements to CALM