Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-#693 changing terminology to architecture #694

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

grahampacker-ms
Copy link
Member

Hopefully this captures all instances of the previous terminology

@rocketstack-matt
Copy link
Member

Do we want to rename shared\src\commands\generate\components\instantiate.ts and associated functions to include along the lines of instantiateArchitecture or we're happy it isn't confusing in the case of the component (as it's actually doing instantiation)?

Copy link
Member

@rocketstack-matt rocketstack-matt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my earlier comment looks good, I don't see any other remaining uses of the word instantiate or instantiation other that in the actually instantiation logic.

I'm approving so you're welcome to merge if you're happy this piece of logic wasn't intended to be renamed, but won't merge in case you do want any further changes.

@grahampacker-ms
Copy link
Member Author

Thanks @rocketstack-matt. I've kept the scope of this to renaming the resulting document to architecture. I think the only cases left are where we're actually instantiating the architecture from the pattern, which I'm fine with.

@grahampacker-ms grahampacker-ms merged commit c0fa2d7 into finos:main Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants