Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppNotFoundException #61

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

BalassaMarton
Copy link
Contributor

Changed AppDirectory.GetApp to throw when the app is not found
Closes #60

@BalassaMarton BalassaMarton requested a review from a team September 21, 2023 07:33
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #61 (7adace6) into main (f725552) will decrease coverage by 1.70%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   83.02%   81.32%   -1.70%     
==========================================
  Files          47       49       +2     
  Lines         383      391       +8     
==========================================
  Hits          318      318              
- Misses         65       73       +8     
Files Coverage Δ
src/Fdc3.AppDirectory/AppDirectoryException.cs 0.00% <0.00%> (ø)
src/Fdc3.AppDirectory/AppNotFoundException.cs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BalassaMarton BalassaMarton force-pushed the appnotfound-exception branch from 1e21075 to e12e9cb Compare October 5, 2023 09:05
@BalassaMarton BalassaMarton force-pushed the appnotfound-exception branch from e12e9cb to cba113e Compare October 5, 2023 13:16
@BalassaMarton BalassaMarton force-pushed the appnotfound-exception branch from cba113e to a5cf5fd Compare October 5, 2023 13:17
@bingenito bingenito merged commit e75e40e into finos:main Oct 5, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetApp should throw if the app is not found
3 participants