Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fdc3) - Fixing AppMetadata could not be deserialized #75

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Nov 28, 2023

Using the package in ComposeUI results JsonSerializer exception as could not deserialize into AppMetadata type. (Could not find images property to match the object).

@lilla28 lilla28 requested a review from a team November 28, 2023 10:39
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8f9881) 77.74% compared to head (31e011e) 77.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   77.74%   77.74%           
=======================================
  Files          49       49           
  Lines         391      391           
  Branches       37       37           
=======================================
  Hits          304      304           
  Misses         73       73           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kruplm kruplm merged commit aae879b into finos:main Nov 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants