fix hashing issue on service store mapping (#1174)

finos · May 23, 2022 · 81b132a · 81b132a
1 parent 5d8c7c3
commit 81b132a
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 7 deletions.
diff --git a/.changeset/giant-eels-hug.md b/.changeset/giant-eels-hug.md
@@ -0,0 +1,5 @@
+---
+"@finos/legend-extension-external-store-service": patch
+---
+
+Fix hashing of service mapping with param definitions ([#1175](https://github.com/finos/legend-studio/issues/1175)).
diff --git a/...els/pure/model/packageableElements/store/serviceStore/mapping/ESService_ServiceMapping.ts b/...els/pure/model/packageableElements/store/serviceStore/mapping/ESService_ServiceMapping.ts
@@ -39,7 +39,7 @@ export class ServiceMapping implements Hashable {
       this.pathOffset
         ? hashObjectWithoutSourceInformation(this.pathOffset)
         : '',
-      this.requestBuildInfo?.toString() ?? '',
+      this.requestBuildInfo ?? '',
     ]);
   }
 }
diff --git a/...model/packageableElements/store/serviceStore/mapping/ESService_ServiceRequestBuildInfo.ts b/...model/packageableElements/store/serviceStore/mapping/ESService_ServiceRequestBuildInfo.ts
@@ -26,8 +26,8 @@ export class ServiceRequestBuildInfo implements Hashable {
   get hashCode(): string {
     return hashArray([
       SERVICE_STORE_HASH_STRUCTURE.SERVICE_REQUEST_BUILD_INFO,
-      this.requestBodyBuildInfo?.toString() ?? '',
-      this.requestParametersBuildInfo?.toString() ?? '',
+      this.requestBodyBuildInfo ?? '',
+      this.requestParametersBuildInfo ?? '',
     ]);
   }
 }
diff --git a/...kageableElements/store/serviceStore/mapping/ESService_ServiceRequestParameterBuildInfo.ts b/...kageableElements/store/serviceStore/mapping/ESService_ServiceRequestParameterBuildInfo.ts
@@ -26,7 +26,7 @@ export class ServiceRequestParameterBuildInfo implements Hashable {
   get hashCode(): string {
     return hashArray([
       SERVICE_STORE_HASH_STRUCTURE.SERVICE_REQUEST_PARAMETER_BUILD_INFO,
-      this.serviceParameter,
+      this.serviceParameter.name,
       this.transform,
     ]);
   }

diff --git a/...re/v1/model/packageableElements/store/serviceStore/mapping/V1_ESService_ServiceMapping.ts b/...re/v1/model/packageableElements/store/serviceStore/mapping/V1_ESService_ServiceMapping.ts
@@ -43,7 +43,7 @@ export class V1_ServiceMapping implements Hashable {
       this.pathOffset
         ? hashObjectWithoutSourceInformation(this.pathOffset)
         : '',
-      this.requestBuildInfo?.toString() ?? '',
+      this.requestBuildInfo ?? '',
     ]);
   }
 }
diff --git a/...el/packageableElements/store/serviceStore/mapping/V1_ESService_ServiceRequestBuildInfo.ts b/...el/packageableElements/store/serviceStore/mapping/V1_ESService_ServiceRequestBuildInfo.ts
@@ -26,8 +26,8 @@ export class V1_ServiceRequestBuildInfo implements Hashable {
   get hashCode(): string {
     return hashArray([
       SERVICE_STORE_HASH_STRUCTURE.SERVICE_REQUEST_BUILD_INFO,
-      this.requestBodyBuildInfo?.toString() ?? '',
-      this.requestParametersBuildInfo?.toString() ?? '',
+      this.requestBodyBuildInfo ?? '',
+      this.requestParametersBuildInfo ?? '',
     ]);
   }
 }