Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Resolving filter in includes not working #1160

Closed
1 task done
MauricioUyaguari opened this issue May 11, 2022 · 0 comments · Fixed by #1165
Closed
1 task done

Bug: Resolving filter in includes not working #1160

MauricioUyaguari opened this issue May 11, 2022 · 0 comments · Fixed by #1165
Assignees
Labels
Extension: Relational Store Studio Core Team Opened by a member of the Studio core team Type: Bug
Milestone

Comments

@MauricioUyaguari
Copy link
Member

MauricioUyaguari commented May 11, 2022

Similar issues

  • I have searched and found no existing similar issues

How are you using Studio?

Legend Studio

Current and expected behavior

graph builder not finding filter in includes store.

Steps to reproduce

3 Issues (2 in studio 1 in engine)

  1. Studio is not resolving filters in includes database
  2. Studio is not serializing the user database input. This causes issues when use types in included database in filter and on the roundtrip we remove the database.
  3. Engine is not resolving filters in includes database unless users provides the included database (Compiler fails to find view filter in included store legend-engine#680)

Model To Reproduce 2

We remove the [store::relational::tests::dbIncWithStoreFilterMain] on the roundtrip.

###Relational
Database store::relational::tests::dbIncWithStoreFilterMain
(
  Schema Mytest
  (
    Table person2Table
    (
      ID INTEGER PRIMARY KEY
    )
  )

  Table personTable
  (
    ID INTEGER PRIMARY KEY,
    FIRSTNAME VARCHAR(200),
    LASTNAME VARCHAR(200),
    AGE INTEGER,
    ADDRESSID INTEGER,
    FIRMID INTEGER,
    MANAGERID INTEGER
  )

  View PersonViewInside
  (
    ~filter PersonFilter
    ID: personTable.ID PRIMARY KEY,
    FIRSTNAME: personTable.FIRSTNAME,
    LASTNAME: personTable.LASTNAME,
    AGE: personTable.AGE
  )

  Filter PersonFilter(personTable.AGE > 110)
)

Database store::relational::tests::dbIncWithStoreFilter
(
  include store::relational::tests::dbIncWithStoreFilterMain

  View PersonView
  (
    ~filter [store::relational::tests::dbIncWithStoreFilterMain]PersonFilter
    ID: personTable.ID PRIMARY KEY,
    FIRSTNAME: personTable.FIRSTNAME,
    LASTNAME: personTable.LASTNAME,
    AGE: personTable.AGE
  )
  View Person2View
  (
    ID: Mytest.person2Table.ID PRIMARY KEY
  )
)

Model to reproduce 1/3

###Relational
Database store::relational::tests::dbIncWithStoreFilterMain
(

  Table personTable
  (
    ID INTEGER PRIMARY KEY,
    FIRSTNAME VARCHAR(200),
    LASTNAME VARCHAR(200),
    AGE INTEGER,
    ADDRESSID INTEGER,
    FIRMID INTEGER,
    MANAGERID INTEGER
  )

)

Database store::relational::tests::dbIncWithStoreFilter
(
  include store::relational::tests::dbIncWithStoreFilterMain

  View PersonView
  (
    ~filter PersonFilter
    ID: personTable.ID PRIMARY KEY,
    FIRSTNAME: personTable.FIRSTNAME,
    LASTNAME: personTable.LASTNAME,
    AGE: personTable.AGE
  )
)

@github-actions github-actions bot added the Studio Core Team Opened by a member of the Studio core team label May 11, 2022
@MauricioUyaguari MauricioUyaguari added this to the 6.0.0 milestone May 11, 2022
@MauricioUyaguari MauricioUyaguari self-assigned this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extension: Relational Store Studio Core Team Opened by a member of the Studio core team Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants