Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find view filter in included store #1165

Merged
merged 1 commit into from
May 13, 2022

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented May 13, 2022

Summary

Fixes #1160

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2022

🦋 Changeset detected

Latest commit: 07d3cea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-manual-tests Patch
@finos/legend-graph Patch
@finos/legend-application Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-extension-mapping-generation Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-query Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-studio Patch
@finos/legend-taxonomy Patch
@finos/legend-query-app Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-taxonomy-app Patch
@finos/legend-query-deployment Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label May 13, 2022
@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review May 13, 2022 17:32
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1165 (07d3cea) into master (1df0754) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
- Coverage   42.89%   42.88%   -0.01%     
==========================================
  Files        1136     1136              
  Lines       49892    49887       -5     
  Branches    11430    11429       -1     
==========================================
- Hits        21401    21395       -6     
- Misses      28419    28420       +1     
  Partials       72       72              
Impacted Files Coverage Δ
...formation/pureGraph/from/V1_DatabaseTransformer.ts 75.37% <0.00%> (-0.39%) ⬇️
...n/pureGraph/to/helpers/V1_DatabaseBuilderHelper.ts 83.83% <0.00%> (+1.71%) ⬆️
...legend-graph/src/helpers/StoreRelational_Helper.ts 69.84% <100.00%> (+0.98%) ⬆️
.../legend-studio/src/components/editor/StatusBar.tsx 59.80% <0.00%> (-4.91%) ⬇️
...egend-studio/src/components/editor/ActivityBar.tsx 58.02% <0.00%> (-1.24%) ⬇️

@akphi akphi merged commit 5fcd423 into finos:master May 13, 2022
@akphi akphi deleted the minorIncludes branch May 13, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Resolving filter in includes not working
2 participants