-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testable (Phase 1) #1114
Testable (Phase 1) #1114
Conversation
🦋 Changeset detectedLatest commit: 547e238 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
- Coverage 42.82% 42.62% -0.20%
==========================================
Files 1125 1128 +3
Lines 49360 49804 +444
Branches 11274 11386 +112
==========================================
+ Hits 21137 21231 +94
- Misses 28153 28503 +350
Partials 70 70
|
53dd1b5
to
4f77814
Compare
d8d09da
to
1b2eaf9
Compare
80ce964
to
431bf38
Compare
431bf38
to
547e238
Compare
packages/legend-graph/src/graphManager/action/changeDetection/Data_ObserverHelper.ts
Show resolved
Hide resolved
packages/legend-graph/src/graphManager/action/changeDetection/Test_ObserverHelper.ts
Show resolved
Hide resolved
packages/legend-graph/src/models/metamodels/pure/test/assertion/status/AssertFail.ts
Show resolved
Hide resolved
packages/legend-graph/src/models/metamodels/pure/test/assertion/EqualTo.ts
Show resolved
Hide resolved
packages/legend-graph/src/models/metamodels/pure/test/assertion/EqualToTDS.ts
Show resolved
Hide resolved
packages/legend-graph/src/models/metamodels/pure/test/assertion/TestAssertion.ts
Show resolved
Hide resolved
packages/legend-studio/src/components/editor/side-bar/testable/TestableManager.tsx
Show resolved
Hide resolved
Left reviews to clean this up since we need to merge this to unblock development. Comments are mostly about cosmetics. The only really major thing is I don't fully grasp why we complicate the extension mechanism, so we should |
Summary
Related to: #1077
Version V0 of testable manager.
With this PR, Users can define testable tests in
text mode
. This includes ones with relational data.Run the tests via the testable manager on the side bar. View failing tests (expected <-> actual) data.
Yet to implement: Testable Editors
Depended on release finos/legend-engine#658 to work but is backward compatible.
How did you test this change?
testable.mp4
TESTDATA FOR VIDEO