Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a regression introduced by #1146 #1155

Merged
merged 2 commits into from
May 10, 2022
Merged

fix a regression introduced by #1146 #1155

merged 2 commits into from
May 10, 2022

Conversation

akphi
Copy link
Contributor

@akphi akphi commented May 10, 2022

The bug is: after pushing local changes, the explorer tree is cleared out

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2022

🦋 Changeset detected

Latest commit: 159e95f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@finos/eslint-plugin-legend-studio Patch
@finos/legend-art Patch
@finos/legend-dev-utils Patch
@finos/legend-query-deployment Patch
@finos/legend-studio Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-deployment Patch
@finos/legend-application Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-extension-mapping-generation Patch
@finos/legend-manual-tests Patch
@finos/legend-query-app Patch
@finos/legend-query Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-taxonomy-app Patch
@finos/legend-taxonomy Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-graph Patch
@finos/legend-model-storage Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-tracer-extension-zipkin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #1155 (159e95f) into master (9e81764) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   42.50%   42.49%   -0.01%     
==========================================
  Files        1131     1131              
  Lines       50018    50017       -1     
  Branches    11433    11433              
==========================================
- Hits        21258    21257       -1     
  Misses      28689    28689              
  Partials       71       71              
Impacted Files Coverage Δ
...s/legend-studio/src/stores/ChangeDetectionState.ts 70.53% <100.00%> (-0.15%) ⬇️

@akphi akphi merged commit aa992e5 into finos:master May 10, 2022
@akphi akphi deleted the bug branch May 10, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants