Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Stubable and more metamodel simplifications #1159

Merged
merged 11 commits into from
May 12, 2022
Merged

Conversation

akphi
Copy link
Contributor

@akphi akphi commented May 11, 2022

Summary

  • Remove Stubable/createStub/isStub
  • Move findPropertyMapping() out of InstanceSetImplementation
  • Minor cleanups and rename helper files to align with DSLs
  • Add some docs for milestoning, including getMilestoneTemporalStereotype()
  • Remove getEmbeddedSetImplmentations() from InstanceSetImplementation
  • IMPORTANT Rename fullPath to path in Package. Where this change really makes a difference is for the root package: previously, path was the name of the root package element, from now on, path will be empty string, this makes the handling of root package when constructing element path more consistent
  • IMPORTANT Move logic out of metamodels, such as Class.getProperty(), Database.getSchema(), etc. and expose them as helper methods.

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2022

🦋 Changeset detected

Latest commit: 735414a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-extension-mapping-generation Patch
@finos/legend-graph Major
@finos/legend-query Patch
@finos/legend-studio Patch
@finos/legend-studio-extension-query-builder Patch
@finos/eslint-plugin-legend-studio Minor
@finos/legend-dev-utils Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-shared Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-studio-app Patch
@finos/legend-application Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-manual-tests Patch
@finos/legend-taxonomy Patch
@finos/legend-query-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-art Patch
@finos/legend-model-storage Patch
@finos/legend-query-deployment Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-app Patch
@finos/legend-taxonomy-deployment Patch
@finos/legend-tracer-extension-zipkin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #1159 (735414a) into master (1e2026e) will increase coverage by 0.11%.
The diff coverage is 56.18%.

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
+ Coverage   42.78%   42.89%   +0.11%     
==========================================
  Files        1132     1136       +4     
  Lines       50037    49891     -146     
  Branches    11441    11430      -11     
==========================================
- Hits        21407    21401       -6     
+ Misses      28559    28418     -141     
- Partials       71       72       +1     
Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/recommended.js 0.00% <ø> (ø)
.../ESService_RootServiceInstanceSetImplementation.ts 100.00% <ø> (+55.55%) ⬆️
...eration/src/components/MappingGenerationEditor.tsx 11.42% <0.00%> (-0.11%) ⬇️
...ckages/legend-graph/src/graph/DependencyManager.ts 36.97% <ø> (ø)
packages/legend-graph/src/graph/PureGraphPlugin.ts 100.00% <ø> (ø)
...graph/src/graphManager/AbstractPureGraphManager.ts 100.00% <ø> (ø)
...d-graph/src/graphManager/PureGraphManagerPlugin.ts 100.00% <ø> (ø)
...nager/action/changeDetection/CoreObserverHelper.ts 52.38% <ø> (ø)
...ction/changeDetection/DSLMapping_ObserverHelper.ts 17.41% <0.00%> (ø)
...ger/action/changeDetection/DomainObserverHelper.ts 23.83% <ø> (ø)
... and 172 more

@akphi akphi force-pushed the stub branch 2 times, most recently from d90861d to 609ab07 Compare May 12, 2022 15:26
@akphi akphi marked this pull request as ready for review May 12, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants