-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service execution runtime showing invalid validation warnings #1163
Conversation
🦋 Changeset detectedLatest commit: 8cd360d The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1163 +/- ##
==========================================
+ Coverage 42.48% 42.89% +0.40%
==========================================
Files 1133 1136 +3
Lines 50009 49892 -117
Branches 11432 11430 -2
==========================================
+ Hits 21247 21401 +154
+ Misses 28692 28419 -273
- Partials 70 72 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we start making get runtimes()
and friends in PureModel
and decorate that with mobx.computed
?
Summary
Closes #1161
How did you test this change?