Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service execution runtime showing invalid validation warnings #1163

Merged
merged 1 commit into from
May 13, 2022

Conversation

gayathrir11
Copy link
Contributor

@gayathrir11 gayathrir11 commented May 13, 2022

Summary

Closes #1161

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label May 13, 2022
@changeset-bot
Copy link

changeset-bot bot commented May 13, 2022

🦋 Changeset detected

Latest commit: 8cd360d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@finos/legend-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-extension-mapping-generation Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-query-app Patch
@finos/legend-taxonomy Patch
@finos/legend-studio-deployment Patch
@finos/legend-manual-tests Patch
@finos/legend-taxonomy-app Patch
@finos/legend-query-deployment Patch
@finos/legend-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1163 (8cd360d) into master (9e3b9b5) will increase coverage by 0.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
+ Coverage   42.48%   42.89%   +0.40%     
==========================================
  Files        1133     1136       +3     
  Lines       50009    49892     -117     
  Branches    11432    11430       -2     
==========================================
+ Hits        21247    21401     +154     
+ Misses      28692    28419     -273     
- Partials       70       72       +2     
Impacted Files Coverage Δ
...it-panel/service-editor/ServiceExecutionEditor.tsx 16.40% <0.00%> (-0.13%) ⬇️
...l/packageableElements/mapping/V1_MappingInclude.ts 28.57% <0.00%> (-33.93%) ⬇️
packages/legend-graph/src/helpers/DomainHelper.ts 68.20% <0.00%> (-24.20%) ⬇️
...s/pure/packageableElements/domain/PrimitiveType.ts 0.00% <0.00%> (-20.00%) ⬇️
...amodels/pure/packageableElements/domain/Package.ts 42.85% <0.00%> (-18.69%) ⬇️
...Elements/store/relational/model/ColumnReference.ts 94.73% <0.00%> (-5.27%) ⬇️
...ents/store/modelToModel/mapping/ObjectInputData.ts 66.66% <0.00%> (-2.57%) ⬇️
...ements/store/relational/model/RelationReference.ts 64.28% <0.00%> (-2.39%) ⬇️
...ts/store/relational/mapping/RelationalInputData.ts 9.09% <0.00%> (-1.44%) ⬇️
...ion/pureGraph/to/helpers/V1_DomainBuilderHelper.ts 82.71% <0.00%> (-1.04%) ⬇️
... and 188 more

@gayathrir11 gayathrir11 marked this pull request as ready for review May 13, 2022 13:01
Copy link
Contributor

@akphi akphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we start making get runtimes() and friends in PureModel and decorate that with mobx.computed?

akphi
akphi previously approved these changes May 13, 2022
@akphi akphi dismissed their stale review May 13, 2022 14:04

wrong click

@akphi akphi merged commit 1df0754 into finos:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
2 participants