Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print ir depth limit #418

Merged
merged 27 commits into from
Sep 18, 2023
Merged

Conversation

edwardpeters
Copy link
Contributor

@edwardpeters edwardpeters commented Sep 13, 2023

This PR updates PrintIR with a number of features to improve succinctness and readability, and integrates it with existing error-generation code.

Additionally, a couple of new unrelated tests snuck into this PR, to cover a case that had not previously been tested.

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for magical-donut-e8221d ready!

Name Link
🔨 Latest commit f7145bf
🔍 Latest deploy log https://app.netlify.com/sites/magical-donut-e8221d/deploys/65087569dfc5fe0008975f52
😎 Deploy Preview https://deploy-preview-418--magical-donut-e8221d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@edwardpeters edwardpeters marked this pull request as draft September 13, 2023 14:44
@deusaquilus
Copy link
Contributor

Please don’t merge this yet

@edwardpeters edwardpeters marked this pull request as ready for review September 18, 2023 15:07
Copy link
Member

@DamianReeves DamianReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DamianReeves DamianReeves merged commit c7b2c4b into finos:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants