Type checker additional tests #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for magical-donut-e8221d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DamianReeves
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the type checker was only running agains the entry point, i.e., checking that arguments were well-formed and matched the definition of the entry point function. This is probably all we want in terms of live performance, but it meantthe tests for the type checker were less rigorous than might be hoped.
This PR adds additional type checker functionality to bulk test all definitions within a set of distributions, and adds such to the type checker test spec. This uncovered a few more minor type checker bugs, which are also fixed here.