Read date32, date64, decimal128 from Arrow datasets #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Reviewed! Looks great - awesome test coverage for this feature as well. Some takeaways for future work:
- Follow up on
streamvsfilearrows across 14 & 15 - we have both seen bugs in this and I suspect it is a 15 regression onfile. - Partial update semantics are not well defined for Arrow yet.
- Type promotion is not well defined.
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading
date32,date64, anddecimal128columns from Arrow-serialized datasets.date32anddate64columns are typed asdate, whiledecimal128columns are typed asint64.Additionally, utility functions have been added for loading Arrows from the filesystem (in JS tests) and generating Arrow binaries using PyArrow (for Python tests). This allows us to quickly add test cases for Arrow datasets in Perspective.