Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth blocking handlers #1080

Merged
merged 22 commits into from
Apr 28, 2022
Merged

Add auth blocking handlers #1080

merged 22 commits into from
Apr 28, 2022

Conversation

colerogers
Copy link
Contributor

@colerogers colerogers commented Apr 18, 2022 •
edited
Loading

Still a WIP until Admin SDK changes are released, the build will FAIL until then.

  • Adds v1 & v2 handlers for auth blocking triggers
  • Adds blockingTrigger to Trigger & Endpoint annotations
  • Adds reference to Admin SDK blocking token verification
  • Yanks custom rolled token verification & decoding
  • Adds Unit tests

@colerogers colerogers requested review from inlined and taeold April 18, 2022 22:18
@colerogers colerogers marked this pull request as ready for review April 22, 2022 21:29
taeold
taeold reviewed Apr 25, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/common/providers/identity.ts Outdated Show resolved Hide resolved
src/common/providers/identity.ts Outdated Show resolved Hide resolved
src/common/providers/identity.ts Show resolved Hide resolved
src/v2/providers/identity.ts Show resolved Hide resolved
src/v2/providers/identity.ts Show resolved Hide resolved
src/v2/providers/identity.ts Outdated Show resolved Hide resolved
spec/v1/providers/auth.spec.ts Outdated Show resolved Hide resolved
spec/v2/providers/identity.spec.ts Outdated Show resolved Hide resolved
tsconfig.release.json Outdated Show resolved Hide resolved
@colerogers colerogers requested a review from taeold April 25, 2022 22:06
taeold
taeold approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - can you bring up skipLibCheck in maybe Firebase CLI chatroom to see if this is "dangerous"

inlined
inlined reviewed Apr 28, 2022
View reviewed changes
Copy link
Member

@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escalating the dom vs skipLibCheck concern. Hang tight.

src/providers/auth.ts Outdated Show resolved Hide resolved
src/v2/providers/identity.ts Outdated Show resolved Hide resolved
@inlined
Add polyfill to avoid depending on DOM or using skipLibCheck (#1085)
4d4d009 
* Add polyfill to avoid depending on DOM or using skipLibCheck

* Formatter

* Linter
@colerogers colerogers merged commit 143eea8 into master Apr 28, 2022
@colerogers colerogers deleted the colerogers.add-auth-blocking-triggers branch April 28, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined inlined left review comments

@taeold taeold taeold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colerogers @inlined @taeold