Lay the groundwork for v3 #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required by `@types/protobufjs`.
joehan
reviewed
Jun 3, 2019
joehan
reviewed
Jun 3, 2019
bkendall
reviewed
Jun 3, 2019
thechenky
reviewed
Jun 3, 2019
|
Thanks for the reviews @bkendall, @joehan, @thechenky! I replied to all of the comments and made some adjustments, I linked commits in some of the replies, so it's easier to review. |
thechenky
reviewed
Jun 5, 2019
thechenky
suggested changes
Jun 5, 2019
|
@merlinnot just those two changes in |
|
Let me know if you need any help on other tasks towards v3. |
thechenky
suggested changes
Jun 6, 2019
|
Also @merlinnot FYI we are going to try to release this today as part of a suite of changes with other products dropping node 6 support. |
|
@thechenky Done! |
dkuspawono
added a commit
to dkuspawono/firebase-functions
that referenced
this pull request
Jun 15, 2019
lay the groundwork v.3(firebase#450)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a foundation for a v3 release of the library, which drops support for Node.js 6. Package version is not changed deliberately, as more breaking changes might be staged in this release.
Although there's not that many changes, I made some well-named commits, so it might be easier to review one by one.
Supersedes #440