Introduce Mocha configuration file #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very nice, I like the exit, those database logs have been pretty annoying that keep printing after the tests finish. Can we change the config file to be json format instead of yaml? Since other files are using json, it would be good to be consistent. |
thechenky
suggested changes
Jul 10, 2019
thechenky
approved these changes
Jul 11, 2019
kevinajian
approved these changes
Jul 12, 2019
|
@merlinnot can you resolve the conflicts so I can merge? |
patilharshal16
approved these changes
Jul 12, 2019
|
@patilharshal16 did you have some comments on this PR? I see you reviewed it....? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While adding some tests to the repository, I noticed it's required to register these in
spec/index.spec.ts. I find that inconvenient, most often all test files are picked up automatically.This PR introduces a Mocha configuration file (introduced in Mocha v6, supersedes now deprecated
mocha.opts). It applies a sane configuration, with a few extras:exitoption which forces Mocha to force the process exit after all tests are finished. I'd treat it as a temporary fix, until the root cause is fixed. It will greatly speed up the CI too. For more information, see https://mochajs.org/#-exitmocha/setup.ts. I'm not sure if that's the most fortunate naming, but I didn't want to mix it with actual test files in thesetupdirectory. I'm open to suggestions!Code sample
Not relevant.