Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable useFetchStreams in the updated WebChannel release #8259

Merged
merged 9 commits into from
Sep 18, 2024

Conversation

MarkDuckworth
Copy link
Contributor

Added a test for the fixed WebChannel issue of reading multi-byte characters that are split across streaming chunks.

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

…test for the fixed WebChannel issue with reading multi-byte characters that are split across multiple streaming chunks.
Copy link

changeset-bot bot commented May 22, 2024

🦋 Changeset detected

Latest commit: 997499e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MarkDuckworth MarkDuckworth requested a review from a team as a code owner May 22, 2024 18:22
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 22, 2024

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (629919e)Merge (2267379)Diff
    browser381 kB381 kB-48 B (-0.0%)
    esm5366 kB366 kB-47 B (-0.0%)
    module381 kB381 kB-48 B (-0.0%)
    react-native382 kB382 kB-47 B (-0.0%)
  • bundle

    TypeBase (629919e)Merge (2267379)Diff
    firestore (CSI Auto Indexing Disable and Delete)270 kB270 kB-20 B (-0.0%)
    firestore (CSI Auto Indexing Enable)270 kB270 kB-20 B (-0.0%)
    firestore (Persistence)305 kB305 kB-20 B (-0.0%)
    firestore (Query Cursors)242 kB242 kB-20 B (-0.0%)
    firestore (Query)240 kB240 kB-20 B (-0.0%)
    firestore (Read data once)228 kB228 kB-20 B (-0.0%)
    firestore (Read Write w Persistence)325 kB325 kB-20 B (-0.0%)
    firestore (Realtime updates)230 kB230 kB-20 B (-0.0%)
    firestore (Transaction)207 kB207 kB-20 B (-0.0%)
    firestore (Write data)207 kB207 kB-20 B (-0.0%)
  • firebase

    TypeBase (629919e)Merge (2267379)Diff
    firebase-compat.js788 kB788 kB-16 B (-0.0%)
    firebase-firestore-compat.js344 kB344 kB-16 B (-0.0%)
    firebase-firestore.js440 kB440 kB-16 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LQTHRcrS0d.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 22, 2024

Size Analysis Report 1

This report is too large (140,160 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/F7YIhtKBHA.html

@MarkDuckworth MarkDuckworth merged commit ff0475c into main Sep 18, 2024
43 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/fetch-streams-multi-byte-fix branch September 18, 2024 15:59
@google-oss-bot google-oss-bot mentioned this pull request Sep 30, 2024
@firebase firebase locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants