-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable useFetchStreams in the updated WebChannel release #8259
Merged
MarkDuckworth
merged 9 commits into
main
from
markduckworth/fetch-streams-multi-byte-fix
Sep 18, 2024
Merged
Re-enable useFetchStreams in the updated WebChannel release #8259
MarkDuckworth
merged 9 commits into
main
from
markduckworth/fetch-streams-multi-byte-fix
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test for the fixed WebChannel issue with reading multi-byte characters that are split across multiple streaming chunks.
🦋 Changeset detectedLatest commit: 997499e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…kduckworth/fetch-streams-multi-byte-fix
Size Report 1Affected Products
Test Logs |
DellaBitta
approved these changes
May 22, 2024
wu-hui
approved these changes
May 22, 2024
Size Analysis Report 1This report is too large (140,160 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
…kduckworth/fetch-streams-multi-byte-fix
…uckworth/fetch-streams-multi-byte-fix
MarkDuckworth
deleted the
markduckworth/fetch-streams-multi-byte-fix
branch
September 18, 2024 15:59
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test for the fixed WebChannel issue of reading multi-byte characters that are split across streaming chunks.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.