Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary console.log statement #8437

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

TheeKia
Copy link
Contributor

@TheeKia TheeKia commented Aug 18, 2024

Following the discussion in issue #8436, I’ve removed an unnecessary console.log statement that appears to have been inadvertently included in a recent commit

@TheeKia TheeKia requested a review from a team as a code owner August 18, 2024 21:13
Copy link

changeset-bot bot commented Aug 18, 2024

🦋 Changeset detected

Latest commit: 283da47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/app Patch
@firebase/app-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

google-cla bot commented Aug 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dlarocque dlarocque self-requested a review August 19, 2024 14:14
@dlarocque
Copy link
Contributor

dlarocque commented Aug 19, 2024

Hey @TheeKia, thanks for submitting this PR.

Could you add a changeset? It's required for this change to cause a version bump and included in the next release. You can do this by running yarn changeset add and selecting @firebase/app to be included as a patch bump.

@TheeKia TheeKia requested review from a team as code owners August 19, 2024 15:43
@TheeKia
Copy link
Contributor Author

TheeKia commented Aug 19, 2024

Hi @dlarocque, I’ve added the changeset as requested, which includes a patch bump for @firebase/app. This is my first PR for Firebase, so please let me know if there’s anything else needed or any further adjustments I should make. Thank you for your guidance!

Copy link
Contributor

@dlarocque dlarocque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dlarocque dlarocque merged commit 05c34c9 into firebase:main Aug 19, 2024
36 of 39 checks passed
@TheeKia TheeKia deleted the remove-console-log branch August 23, 2024 09:20
@google-oss-bot google-oss-bot mentioned this pull request Aug 27, 2024
@firebase firebase locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants