Skip to content

Commit

Permalink
Fix bug in #7314 (#7321)
Browse files Browse the repository at this point in the history
  • Loading branch information
joehan authored Jun 13, 2024
1 parent 6adc9f7 commit 52bf804
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/emulator/downloadableEmulators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ const Commands: { [s in DownloadableEmulators]: DownloadableEmulatorCommand } =
shell: false,
},
pubsub: {
binary: `"${getExecPath(Emulators.PUBSUB)!}"`,
binary: `${getExecPath(Emulators.PUBSUB)!}`,
args: [],
optionalArgs: ["port", "host"],
joinArgs: true,
Expand All @@ -287,7 +287,7 @@ const Commands: { [s in DownloadableEmulators]: DownloadableEmulatorCommand } =
shell: false,
},
dataconnect: {
binary: `"${getExecPath(Emulators.DATACONNECT)}"`,
binary: `${getExecPath(Emulators.DATACONNECT)}`,
args: ["dev"],
optionalArgs: [
"listen",
Expand Down Expand Up @@ -441,6 +441,9 @@ async function _runBinary(
};
if (command.shell && utils.IS_WINDOWS) {
opts.shell = true;
if (command.binary.includes(" ")) {
command.binary = `"${command.binary}"`;
}
}
emulator.instance = childProcess.spawn(command.binary, command.args, opts);
} catch (e: any) {
Expand Down

0 comments on commit 52bf804

Please sign in to comment.