Add a message if the public folder is not declared in the hosting con…

…fig (#2015) * Add a message if the public folder is not declared in the hosting config * Add changelog entry for public parameter warning * change changelog to a list Co-authored-by: Bryan Kendall <[email protected]>
firebase · Mar 6, 2020 · 9c687ad · 9c687ad
1 parent 5860f52
commit 9c687ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,2 +1,3 @@
-Adds warning message when installing a closed or open alpha extension.
-Adds support for scheduled pubsub functions to pubsub emulator.
+- Adds warning message when installing a closed or open alpha extension.
+- Adds support for scheduled pubsub functions to pubsub emulator.
+- Returns an error if the `public` parameter is not configured for Hosting in `firebase.json` or via the `-p` parameter.
diff --git a/src/deploy/hosting/prepare.js b/src/deploy/hosting/prepare.js
@@ -55,6 +55,12 @@ module.exports = function(context, options) {
       throw new FirebaseError('Must supply either "site" or "target" in each "hosting" config.');
     }
 
+    if (!cfg.public) {
+      throw new FirebaseError(
+        'Must supply a public directory using "public" in each "hosting" config.'
+      );
+    }
+
     if (!fsutils.dirExistsSync(resolveProjectPath(options.cwd, cfg.public))) {
       throw new FirebaseError(
         `Specified public directory '${cfg.public}' does not exist, ` +