Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeveloperConnect: make fetchLinkableGitRepositories list all linkable git repositories #6889

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

mathu97
Copy link
Contributor

@mathu97 mathu97 commented Mar 19, 2024

Description

Instead of fetching a certain page of linkable git repos, fetchLinkableGitRepositories has been updated to fetch all linkable git repositories, iterating over all pages. This will behave similar to listConnections (renamed to listAllConnections)

Follow up from: https://github.com/firebase/firebase-tools/pull/6887/files/d8841df93bac3c0dbcb8773783db627015842094#r1530608858

@mathu97 mathu97 force-pushed the mathusan/dev-connect-fetchlinkable-repos-fix branch from 3da72f5 to 90f4afa Compare March 19, 2024 18:18
@mathu97 mathu97 changed the title DeveloperConnect: make fetchLinkableGitRepositories get all linkable git repositories DeveloperConnect: make fetchLinkableGitRepositories list all linkable git repositories Mar 19, 2024
@mathu97 mathu97 requested a review from tonyjhuang March 19, 2024 18:19
@mathu97 mathu97 force-pushed the mathusan/dev-connect-fetchlinkable-repos-fix branch from 90f4afa to 3d04b8b Compare March 19, 2024 19:11
@mathu97 mathu97 requested a review from tonyjhuang March 20, 2024 14:36
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.32%. Comparing base (82d3337) to head (50da6e7).

Files Patch % Lines
src/gcp/devConnect.ts 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6889      +/-   ##
==========================================
+ Coverage   54.30%   54.32%   +0.02%     
==========================================
  Files         353      353              
  Lines       24578    24583       +5     
  Branches     5086     5086              
==========================================
+ Hits        13346    13355       +9     
+ Misses      10019    10014       -5     
- Partials     1213     1214       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathu97 mathu97 merged commit dc13cb9 into master Mar 25, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants