[Deploy preview] Allow seeing different assembly code for the same function #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstange
force-pushed
the
assembly-view-prev-next
branch
from
49d95a4 to
139d000
Compare
mstange
force-pushed
the
assembly-view-prev-next
branch
from
139d000 to
74b06df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a JS function is JIT compiled multiple times, then it's currently impossible to see the assembly code for each compilation. If you double-click the call node for the function, the assembly view shows an arbitrary compilation. It doesn't even try to find the one with the highest sample count.
This PR makes it so that the compilation with the highest sample count is chosen, and allows navigating between the different compilations.