Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show size units in the timeline for size profiles #5364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fqueze
Copy link
Contributor

@fqueze fqueze commented Feb 10, 2025

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 48 lines in your changes missing coverage. Please review.

Project coverage is 85.74%. Comparing base (7f30744) to head (63ccd74).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/format-numbers.js 41.66% 25 Missing and 3 partials ⚠️
src/components/timeline/Ruler.js 32.14% 14 Missing and 5 partials ⚠️
src/profile-logic/committed-ranges.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5364      +/-   ##
==========================================
- Coverage   85.84%   85.74%   -0.10%     
==========================================
  Files         312      312              
  Lines       29827    29886      +59     
  Branches     8213     8246      +33     
==========================================
+ Hits        25605    25626      +21     
- Misses       3627     3660      +33     
- Partials      595      600       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstange
Copy link
Contributor

mstange commented Feb 14, 2025

I think this is cool idea. But I think it shouldn't be magically based on threads[0].samples.weightType - it's something that affects all threads and it should be explicitly set in the profile, for example inside profile.meta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants