Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the codebase and remove the issues with timeouts, race conditions and dead code #28

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Simplify the codebase and remove the issues with timeouts, race conditions and dead code #28

merged 9 commits into from
Jul 17, 2024

Conversation

AndrewDryga
Copy link
Contributor

No description provided.

@AndrewDryga AndrewDryga requested a review from jamilbk July 17, 2024 02:44
jamilbk
jamilbk approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will test live after it's deployed and see if we need to make any last-minute fixes.

nice cleanup!

@AndrewDryga AndrewDryga merged commit bc6f453 into main Jul 17, 2024
1 check passed
@AndrewDryga AndrewDryga deleted the andrew/refactor branch July 17, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewDryga @jamilbk