Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Loading Image and Update ProjecCards Component #441

Open
wants to merge 1 commit into
base: source
Choose a base branch
from
Open

Add Loading Image and Update ProjecCards Component #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added public/Loading-image.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 9 additions & 3 deletions src/components/ProjectList/ProjectsCards.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import React from "react";
import "./css/project-cards.css";

const defaultImage ="/Loading-image.png"

const Card = ({
projectLink,
logoLink,
Expand All @@ -22,11 +24,15 @@ const Card = ({
<div className="Card-Container">
<a className="Card-Real-Link" href={projectLink} target='blank'>
<div className="Card-Header">
<img
<img
className="Project-Logo"
alt="the framework or language that the project is build upon"
alt={logoLink}
src={logoLink}
/>
onError={(e) => {
e.target.onerror = null; // Prevents infinite loop if fallback also fails
e.target.src = defaultImage; // Set default image if loading fails
}}
/>
<p className="Card-Title">{name}</p>
</div>
<div className="Card-Body">
Expand Down
Loading