Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added environment as a kubernetes resource definition #175

Merged
merged 2 commits into from
Jul 24, 2018

Conversation

erwinvaneyk
Copy link
Member

This fixes #168

@erwinvaneyk
Copy link
Member Author

@xiekeyang could you review this change?

@xiekeyang
Copy link
Contributor

@erwinvaneyk

This provides the workflow environment solution via helm chart installation. However, general customer have no permission to use helm install, which need kube admin privilege (like open shift platform).

So customer might like to use command fission spec apply --specdir <workflow-env-dir>, or kubectl spec apply -f <env.yaml> to create a workflow env.

What is more, customer might want to fill more parameters like resource setting, self-defined environment variables, etc, which is not involved in currant template. If we paste all possible parameters in template, it will be too long-winded.

So, IMO, we can provide:

a) Just address this PR. And we supply some doc, let reader know they can follow this template, and fill their own parameters in it. And suggest customers to create workflow env via fission or kubectl command.

b) Provide a simple workflow-env yaml sample file, with filling the necessary parameters, instead template. Put the yaml file to dir like hack/env/specs/ or example/env/specs... Let customer know they can create it by fission or kubectl. And customer will do this according to their user cases.

I think the above ways are both OK.

@xiekeyang
Copy link
Contributor

xiekeyang commented Jul 19, 2018

charts/fission-workflows/templates/deployment.yaml is an available environment spec, with removing all variables. I feel we need not to use helm command (inhack/codegen-helm.sh) any more, fission spec apply is better?

@erwinvaneyk
Copy link
Member Author

@xiekeyang -- agreed, with the directory change. It might be better to move this to the example dir to indicate that it is just an example of a workflow env definition. The codegen script is just for me/developers to keep the helm templates in sync with the example specification. Users should not need it or helm to use the spec

@erwinvaneyk erwinvaneyk force-pushed the workflow-env-crd branch 2 times, most recently from 0afd280 to e6b2c2c Compare July 20, 2018 10:02
This should now make it possible again to cancel the workflow by closing
the HTTP connection.
@erwinvaneyk erwinvaneyk merged commit cb6ff9d into master Jul 24, 2018
@erwinvaneyk erwinvaneyk deleted the workflow-env-crd branch July 24, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment Workflow should be general function environment
2 participants