Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable HAProxy Advanced Redis Health Check #19

Open
fititnt opened this issue Nov 24, 2019 · 2 comments
Open

Configurable HAProxy Advanced Redis Health Check #19

fititnt opened this issue Nov 24, 2019 · 2 comments

Comments

@fititnt
Copy link
Owner

fititnt commented Nov 24, 2019


This issue is not about create a role to install Redis without external dependencies (...not yet) but to allow some way to, via specifications under some alb_* variables, make changes on the HAProxy component of AP-ALB to deploy already well tested HAProxy Advanced Redis Health Check.

At the https://github.com/fititnt/ap-alb-cluster-demo we're testing role davidwittman.redis and could just make ALB play very nice with this and document very well.

fititnt added a commit that referenced this issue Nov 24, 2019
…: created haproxy-standard.cfg.j2 from haproxy-minimal.cfg.j2
fititnt added a commit that referenced this issue Nov 25, 2019
…: new folder convention for store HAProxy (and 'NLB strategies')
@fititnt
Copy link
Owner Author

fititnt commented Nov 25, 2019

Good to know that the official HAProxy configuration for redis have at https://www.haproxy.com/blog/haproxy-advanced-redis-health-check/ seems to not work with lastest version of HAProxy because of missings "".

So what in the documentation was

backend bk_redis
 option tcp-check
 tcp-check send PINGrn
 tcp-check expect string +PONG
 tcp-check send info replicationrn
 tcp-check expect string role:master
 tcp-check send QUITrn
 tcp-check expect string +OK
 server R1 10.0.0.11:6379 check inter 1s
 server R2 10.0.0.12:6379 check inter 1s

Should be more like

(...)
     tcp-check send PING\r\n
     tcp-check expect string +PONG
     tcp-check send info\ replication\r\n
     tcp-check expect string role:master
     tcp-check send QUIT\r\n
     tcp-check expect string +OK
     server delta 173.249.10.99:6379 check inter 5s
     server echo 167.86.127.220:6379 check inter 5s
     server foxtrot 167.86.127.225:6379 check inter 5s

@fititnt
Copy link
Owner Author

fititnt commented Dec 3, 2019

I put this on-hold for now.

This is not a priority for the ALB v0.8.x and clustering related options #17, in special because of this commend #22 (comment) and the MVP of Consul storage adapter to lua-resty-auto-ssl #25 have a working redis cluster is not a strong requisite.

Anyway, have this type of health check still very interesting. Maybe will do it if start to make AP-ALB also have health checks for other databases like MariaDB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant