Upgrade Ember CLI and align with default blueprint #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
changed the title
SergeAstapov
commented
Oct 12, 2017
tests/integration/smoke-test.js
Outdated
| @@ -13,10 +13,6 @@ test("doesn't put in keys unless they are explicitly allowed", function(assert){ | |||
| assert.equal(Object.hasOwnProperty.call(ENV, "DO_NOT_ALLOW"), false); | |||
| }); | |||
|
|
|||
| test("puts keys in the node process ENV always", function(assert){ | |||
There was a problem hiding this comment.
@fivetanley it's not supported as of [email protected] - removed as it breaks the build and is not supported any more.
Gonna make PR to update readme with note about it.
|
Tests should be green after #29 is merged |
|
Tests are gonna be fixed in a follow up PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite to get FastBoot support requested in #24.
I'm gonna make a follow up PR with FastBoot support implementation as soon as this get's merged.