moved add comment page into modal on analysis page

[jstucke]

No description provided.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (058e49f) to head (516cadb).
Report is 24 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
- Coverage   92.42%   91.80%   -0.63%     
==========================================
  Files         379      376       -3     
  Lines       23661    21044    -2617     
==========================================
- Hits        21869    19319    -2550     
+ Misses       1792     1725      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maringuu]

I'm not convinced that a modal is appropriate here.
It still hides part of the information displayed on the page of the file you are commenting on.
Why not add a text input field where you can type to the comments section?

Aside:
The modal is kind of narrow and can only be resized vertically but not horizontally.

[jstucke]

I'm not convinced that a modal is appropriate here. It still hides part of the information displayed on the page of the file you are commenting on. Why not add a text input field where you can type to the comments section?

Aside: The modal is kind of narrow and can only be resized vertically but not horizontally.

It was @dorpvom's idea to use a modal. I agree that a modal might not be the best choice (because you might want to look at the analysis page while commenting). Let's hear @dorpvom's opinion on this.

[dorpvom]

I have opined

[jstucke]

I changed it, moved it out of the modal and integrated it into the table where the "add comment" button is located.

[maringuu]

Nice! Lgtm