Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: converted info leaks plugin to new base class #1325

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Jan 14, 2025

No description provided.

@jstucke jstucke self-assigned this Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (bfba5e0) to head (3c21420).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
- Coverage   92.50%   91.84%   -0.67%     
==========================================
  Files         381      376       -5     
  Lines       24219    21021    -3198     
==========================================
- Hits        22404    19306    -3098     
+ Misses       1815     1715     -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@maringuu maringuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maringuu
Copy link
Collaborator

Rebased manually, because github somehow refused to. Will merge once CI is done.

@jstucke
Copy link
Collaborator Author

jstucke commented Jan 16, 2025

Rebased manually, because github somehow refused to. Will merge once CI is done.

What did you do to achieve this? 😅

@maringuu
Copy link
Collaborator

Dunno, it told me sth. along the lines of "Base branch changed". The branch rebased without conflicts locally.

Anyways, somehow one test fails on Ubuntu noble.

@jstucke
Copy link
Collaborator Author

jstucke commented Jan 16, 2025

rebased on master again to remove AnalysisBasePluginAdapterMixin

@jstucke jstucke merged commit 635f62d into master Jan 31, 2025
9 checks passed
@jstucke jstucke deleted the info-leaks-v1 branch January 31, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants