Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get_yara_error should not return None over the intercom #1336

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Jan 27, 2025

No description provided.

@jstucke jstucke self-assigned this Jan 27, 2025
@jstucke jstucke marked this pull request as ready for review January 27, 2025 16:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (57e7c49) to head (ab382ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
- Coverage   92.53%   91.84%   -0.70%     
==========================================
  Files         381      376       -5     
  Lines       24245    21056    -3189     
==========================================
- Hits        22435    19338    -3097     
+ Misses       1810     1718      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhelmke rhelmke self-requested a review January 28, 2025 10:58
Copy link
Collaborator

@rhelmke rhelmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@rhelmke rhelmke merged commit 78ad88d into master Jan 28, 2025
10 checks passed
@rhelmke rhelmke deleted the intercom-none-bugfix branch January 28, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants