Skip to content

Commit

Permalink
Added runtime selection of 'power' config family. (#718)
Browse files Browse the repository at this point in the history
Details:
- Created a 'power' umbrella configuration family, which, when targeted 
  at configure-time, will build both 'power9' and 'power10' subconfigs. 
  (With this feature, a BLIS shared library could be compiled on a 
  power9 system and run on power10 and vice-versa. Unoptimised code
  will execute if it is linked and run on any other generic system.)
- This new configuration family will only work with gcc, since that is
  the only compiler supported by both power9 and power10 subconfigs in 
  BLIS.
- Documented power9 and power10 as supported microarchitectures in the
  docs/HardwareSupport.md document.
  • Loading branch information
nisanthmp authored Feb 8, 2023
1 parent e730c68 commit e3d352f
Show file tree
Hide file tree
Showing 6 changed files with 134 additions and 2 deletions.
41 changes: 41 additions & 0 deletions config/power/bli_family_power.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/*
BLIS
An object-based framework for developing high-performance BLAS-like
libraries.
Copyright (C) 2014, The University of Texas at Austin
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
- Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
- Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
- Neither the name(s) of the copyright holder(s) nor the names of its
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

//#ifndef BLIS_FAMILY_H
//#define BLIS_FAMILY_H



//#endif

82 changes: 82 additions & 0 deletions config/power/make_defs.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
#
#
# BLIS
# An object-based framework for developing high-performance BLAS-like
# libraries.
#
# Copyright (C) 2014, The University of Texas at Austin
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
# - Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# - Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in the
# documentation and/or other materials provided with the distribution.
# - Neither the name(s) of the copyright holder(s) nor the names of its
# contributors may be used to endorse or promote products derived
# from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
# HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#
#


# Declare the name of the current configuration and add it to the
# running list of configurations included by common.mk.
THIS_CONFIG := power
#CONFIGS_INCL += $(THIS_CONFIG)

#
# --- Determine the C compiler and related flags ---
#

# NOTE: The build system will append these variables with various
# general-purpose/configuration-agnostic flags in common.mk. You
# may specify additional flags here as needed.
CPPROCFLAGS :=
CMISCFLAGS :=
CPICFLAGS :=
CWARNFLAGS :=

ifneq ($(DEBUG_TYPE),off)
CDBGFLAGS := -g
endif

ifeq ($(DEBUG_TYPE),noopt)
COPTFLAGS := -O0
else
COPTFLAGS := -O2
endif

# Flags specific to optimized kernels.
CKOPTFLAGS := $(COPTFLAGS) -O3
CKVECFLAGS :=

# Flags specific to reference kernels.
CROPTFLAGS := $(CKOPTFLAGS)
ifeq ($(CC_VENDOR),gcc)
CRVECFLAGS := $(CKVECFLAGS) -funsafe-math-optimizations -ffp-contract=fast
else
ifeq ($(CC_VENDOR),clang)
CRVECFLAGS := $(CKVECFLAGS) -funsafe-math-optimizations -ffp-contract=fast
else
CRVECFLAGS := $(CKVECFLAGS)
endif
endif

# Store all of the variables here to new variables containing the
# configuration name.
$(eval $(call store-make-defs,$(THIS_CONFIG)))

1 change: 1 addition & 0 deletions config_registry
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ amd64_legacy: excavator steamroller piledriver bulldozer generic
amd64: zen3 zen2 zen generic
arm64: armsve firestorm thunderx2 cortexa57 cortexa53 generic
arm32: cortexa15 cortexa9 generic
power: power10 power9 generic

# Intel architectures.
skx: skx/skx/haswell/zen
Expand Down
2 changes: 2 additions & 0 deletions docs/HardwareSupport.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ A few remarks / reminders:
| ARMv8.1 A64FX (SVE) | `a64fx` | `d` | |
| IBM Blue Gene/Q (QPX int) | `bgq` | `d` | |
| IBM Power7 (QPX int) | `power7` | `d` | |
| IBM Power9 | `power9` | `sdcz` | |
| IBM Power10 | `power10` | `sdcz` | |
| template (C99) | `template` | `sdcz` | `sdcz` |

## Level-1f kernels
Expand Down
3 changes: 2 additions & 1 deletion frame/base/bli_arch.c
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ arch_t bli_arch_query_id_impl( void )
defined BLIS_FAMILY_AMD64 || \
defined BLIS_FAMILY_X86_64 || \
defined BLIS_FAMILY_ARM64 || \
defined BLIS_FAMILY_ARM32
defined BLIS_FAMILY_ARM32 || \
defined BLIS_FAMILY_POWER
id = bli_cpuid_query_id();
#endif

Expand Down
7 changes: 6 additions & 1 deletion frame/include/bli_arch_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,12 @@ CNTX_INIT_PROTS( generic )
#include "bli_family_cortexa9.h"
#endif

// -- IBM Power --
// -- IBM Power families --
#ifdef BLIS_FAMILY_POWER
#include "bli_family_power.h"
#endif

// -- IBM Power architectures --

#ifdef BLIS_FAMILY_POWER10
#include "bli_family_power10.h"
Expand Down

0 comments on commit e3d352f

Please sign in to comment.