bli_pool: add sanity check in bli_pool_free_block() #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: - In case of pool reinit due to a thread asking for a bigger block, the pool is re-initialized and all blocks are free-ed, including potential ones already checked out and being used elsewhere. Those empty slots are marked with NULL pointer and hence we should skip calling free() on them (with subtraction by offset_size). - The orphaned blocks and their pointers will be free-ed later when checking in back by the existing check-in mechanism.
|
@hominhquan I believe the problems leading to this PR were fixed recently in #670 and #671. If not, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
pool is re-initialized and all blocks are free-ed, including potential
ones already checked out and being used elsewhere. Those empty slots
are marked with NULL pointer and hence we should skip calling free()
on them (with subtraction by offset_size).
checking in back by the existing check-in mechanism.