Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test driver fix for her, her2, herk and her2k #578

Merged
merged 6 commits into from
Nov 17, 2021

Conversation

madanm3
Copy link
Contributor

@madanm3 madanm3 commented Nov 16, 2021

Bug fix done driver code.

  • API mismatch were fixed and data type supported test has been added.

madanm3 and others added 5 commits November 11, 2021 19:08
Fixed test driver code for her, her2, herk and her2k function.
Above functions supports only complex and double complex data type, test code is updated accordingly.

Change-Id: Iee7b79abda4a2959a265c420d23879bf47f2c38d
AMD-Internal: [CPUPL-1313]
Fixed test driver code for her, her2
Support added to handle complex and double complex data type in test driver.

Change-Id: If65939e99d8cf77e0fb70561166d84bf67d0321d
AMD-Internal: [CPUPL-1326]
Fixed test driver code for her, her2, herk and her2k function.
Above functions supports only complex and double complex data type, test code is updated accordingly.

Change-Id: Iee7b79abda4a2959a265c420d23879bf47f2c38d
AMD-Internal: [CPUPL-1313]
Fixed test driver code for her, her2
Support added to handle complex and double complex data type in test driver.

Change-Id: If65939e99d8cf77e0fb70561166d84bf67d0321d
AMD-Internal: [CPUPL-1326]
Details:
- Added conditional branches for calling real domain syr, syr2, syrk,
  and syr2k BLAS interfaces in the test_her.c, test_her2.c, test_herk.c,
  and test_her2k.c driver files in the 'test' directory.
@fgvanzee
Copy link
Member

fgvanzee commented Nov 16, 2021

@madanm3 Thanks for your fixes. I added the real domain syr/syr2/syrk/syr2k calls to the driver files since the driver files are not literally intended to refer only to complex domain her/her2/herk/her2k. Rather, we often use the herk operation, for example, to refer to the pair of operations including real domain syrk plus complex domain herk. (Notice that if you perform herk on a real domain matrix, you've actually performed the equivalent of syrk on the same matrix. Thus, the herk operation name is the most generalized way of referring to both situations.)

@fgvanzee
Copy link
Member

PS: I cancelled the Travis CI build since there is no way these changes could affect the library.

@fgvanzee fgvanzee merged commit 9be97c1 into flame:master Nov 17, 2021
dzambare pushed a commit to Meghana-vankadari/blis that referenced this pull request Jan 6, 2022
Details:
- Replaced the hard-coded calls to double-precision real syr, syr2, 
  syrk, and syrk in the corresponding standalone test drivers in the 
  'test' directory with conditional branches that will call the 
  appropriate BLAS interface depending on which datatype is enabled. 
  Thanks to Madan mohan Manokar for this improvement.
- CREDITS file update.
fgvanzee added a commit that referenced this pull request Sep 10, 2022
Details:
- Replaced the hard-coded calls to double-precision real syr, syr2,
  syrk, and syrk in the corresponding standalone test drivers in the
  'test' directory with conditional branches that will call the
  appropriate BLAS interface depending on which datatype is enabled.
  Thanks to Madan mohan Manokar for this improvement.
- CREDITS file update.
- (cherry picked from commit 9be97c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants