De-template the sup_var1n2m code and combine A/B packing functions. #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables better debugging since errors will show up based on the un-flattened filename and line number.
# Conflicts: # build/flatten-headers.py # frame/3/bli_l3_sup_var1n2m.c
|
@fgvanzee ready to review and merge. |
|
@devinamatthews This looks good. You did a great job of keeping formatting and limiting changes to just those necessary for the de-templatization, which made it much easier to compare the before and after. 👍 I converted some |
fgvanzee
added a commit
that referenced
this pull request
Oct 26, 2023
Details: - Re-expressed the two variants in frame/3/bli_l3_sup_var1n2m.c as a single function each that performs char* pointer arithmetic rather than four datatype-specific functions. Did the same for the functions in bli_l3_sup_packm_a.c and _sup_packm_b.c, and then unified the two into a single set of functions for packing either A or B, which now resides in bli_l3_sup_packm.c. - Pre-grow the cntl_t tree in both bli_l3_sup_var1n2m.c variants rather than grow them incrementally. - Relocated empty-matrix and scale-by-beta early return handlnig from bli_gemm_front() and bli_gemmt_front() to their _ex() counterparts. - Comment, whitespace updates. - (cherry picked from commit 89df7b8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.