better zsh code completion #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
May 13, 2022
* Adds links to sponsors in README * Adds AnonAddy to the sponsor list * adds a more comprehensive zsh completion * fix the extra square brackets * fix the CMakeLists to handle the new paths (cherry picked from commit 6cd9d9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed multiple code completions including
arch-audit,pamac, andnvm. I ultimately ended up finding thepamacstyle and flow much more cleaner and more compatible with our style of CLI. So I adopted that and modified it according to Flameshot's CLI subcoimmands and args.Unfortunately this is not compatible with bash and therefore I renamed the one @veracioux made to be only for bash, and added this one for zsh.
I'm [as always] open to any suggestion/comments/feedback 😃