Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinwidget: allow moving widget partially outside of screen under linux #2520

Merged

Conversation

zhangfuwen
Copy link
Contributor

add a window flag to pinwidget, allowing pinwidget to be moved partially out side of screen. compile and tested under linux.

@mmahmoudian
Copy link
Member

mmahmoudian commented Apr 2, 2022

For the record this addresses #1786

@borgmanJeremy
Copy link
Contributor

Thank you! this is much simpler than my method. Can you please apply clang-format and I will get it merged?

@zhangfuwen zhangfuwen force-pushed the pinwidget_outof_screen branch from bff86b5 to 74907b6 Compare April 6, 2022 09:51
@zhangfuwen
Copy link
Contributor Author

Thank you! this is much simpler than my method. Can you please apply clang-format and I will get it merged?

@borgmanJeremy done it.

@borgmanJeremy
Copy link
Contributor

Thanks!

@wurenny
Copy link

wurenny commented Apr 29, 2022

@zhangfuwen Thanks, but why do I need to press the ALT key to move out of the screen? see: #2569
OS:Linux Mint 20.2 with Cinnamon 5.0.7
Flameshot v11.0.0 ()
Compiled with Qt 5.12.8

@mmahmoudian
Copy link
Member

mmahmoudian commented Apr 29, 2022

@wurenny you have got it all wrong. Here are some facts that you are not considering:

  1. you are using Flameshot v11.0.0 () (released on Jan 15, 2022)
  2. this PR was merged 23 days ago (April 6, 2022) which at the moment has the version of v11.0.0 (850260d)
  3. the alt functionality you are using are not provided by Flameshot, but rather from your Window Manager (more info here)
  4. the Pin image can not penetrates the edge of the screen with Linux mint 20.2 #2569 is complete duplicate of Pinned screenshot on linux can't be moved outside the screen #1786

The number in front of the version number in parenthesis is the git commit ID. If you compile Flameshot from source, you will get that number. What it means is that your Flameshot is some commits "ahead" of the v11.0.0 .

Now, if you need/want to get the latest features and bug fixes (and possibly some new bugs), you can always download out nightly builds and install them manually. Please note that if you do so, your package manager (apt/flatpak/snap) will not be able to update this particular software as you have manually installed it, so you should manually update it as well via the same process.

@wurenny
Copy link

wurenny commented Apr 29, 2022

@mmahmoudian ok thank you for such a detailed analysis, i'll wait for the next release, and work with the ALT key for now.

panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request May 13, 2022
gepbird added a commit to gepbird/flameshot that referenced this pull request Aug 29, 2023
…der linux (flameshot-org#2520)"

This reverts commit 850260d.
Fix for flameshot-org#2768
(but breaks another issue so dont merge upstream)
gepbird added a commit to gepbird/flameshot that referenced this pull request Aug 1, 2024
…der linux (flameshot-org#2520)"

This reverts commit 850260d.
Fix for flameshot-org#2768
(but breaks another issue so dont merge upstream)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants