Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pinwidget save #2549

Merged
merged 2 commits into from
May 1, 2022
Merged

Fix pinwidget save #2549

merged 2 commits into from
May 1, 2022

Conversation

Alaskra
Copy link
Contributor

@Alaskra Alaskra commented Apr 15, 2022

fix the bug

@mmahmoudian
Copy link
Member

Out if curiosity, wouldn't toggling the Qt::WindowStaysOnTopHint be feasible?

@Alaskra
Copy link
Contributor Author

Alaskra commented Apr 15, 2022

Actually the Qt::X11BypassWindowManagerHint flag have the effect of stay on top. If pinned picture is partially off-screen, switch Qt::X11BypassWindowManagerHint off and on will cause position change. So I think hide and show is easier.

@borgmanJeremy borgmanJeremy merged commit 724a28f into flameshot-org:master May 1, 2022
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request May 13, 2022
@Alaskra
fix the cover problem when save pinned picture. (flameshot-org#2549)
cf023f8 
(cherry picked from commit 724a28f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alaskra @mmahmoudian @borgmanJeremy